Open
Conversation
Now that we want to fuzz stack switching against a real implementation in V8, add proper validation. Copy in the stack switching tests, commenting out parts we do not handle for other reasons, to test that the new validation logic is correct. Fix DAE2 and a couple of stack switching tests that were not actually valid to begin with.
kripken
reviewed
Mar 16, 2026
| // and $ct_handler must be cont [t2_tag*] -> [sig.results] | ||
| // But we cannot check this here because we do not know what type the | ||
| // block named $label expects. Save the tag to check when we visit the | ||
| // block later. |
Member
There was a problem hiding this comment.
I wonder if we could make all this simpler by pre-visiting blocks. But I guess we can consider that separately.
| ;; OPEN_WORLD: (tag $tag (type $none)) | ||
| (tag $tag (type $none)) | ||
| ;; OPEN_WORLD: (tag $tag (type $2) (result i32)) | ||
| (tag $tag (result i32)) |
Member
There was a problem hiding this comment.
Why did this change? I don't see how the result is used below.
Member
|
lgtm otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we want to fuzz stack switching against a real implementation in V8, add proper validation. Copy in the stack switching tests, commenting out parts we do not handle for other reasons, to test that the new validation logic is correct. Fix DAE2 and a couple of stack switching tests that were not actually valid to begin with.