Skip to content

Add initial packed waitqueue type#8323

Open
stevenfontanella wants to merge 2 commits intomainfrom
waitqueue
Open

Add initial packed waitqueue type#8323
stevenfontanella wants to merge 2 commits intomainfrom
waitqueue

Conversation

@stevenfontanella
Copy link
Member

@stevenfontanella stevenfontanella commented Feb 13, 2026

Part of #8315. Adds initial binary + text parsing and printing for the packed waitqueue type.

@stevenfontanella stevenfontanella marked this pull request as ready for review February 13, 2026 07:26
not_packed,
i8,
i16,
WaitQueue,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks inconsistent with the existing values, in particular not_packed vs WaitQueue?

Which proposal is this from btw? I'd like to read the background.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context is in the linked issue and in particular in Thomas's issue. I'm implementing the second paragraph in that issue which is WaitQueue as a packed type. Since I'm implementing it as a packed type, I think this is the right place for this but let me know if I got it wrong.

The problem that we're trying to solve is that WaitQueue needs to be partially opaque, but we'd also like existing struct accessors to be able to mutate its control word.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that you meant the naming. I don't mind changing it, but it looks like most enums values in this repo use PascalCase, maybe we should change not_packed to NotPacked instead? Either way is ok to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, maybe it should be NotPacked. I guess we can leave that as separate from this PR then.

Reading some of the discussion on the substance, this seems... complicated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a decision though on planning to rename to NotPacked, or something else. I think I'd be in favor of that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! Will change it in the next PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg, though actually let's wait for @tlively to weigh in, as maybe there was a reason for not_packed that I don't recall...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotPacked sgtm

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the spec discussion is ongoing but lgtm to land this if it helps investigation for the spec.

@kripken
Copy link
Member

kripken commented Feb 13, 2026

Oh, I would fuzz this before landing. I wouldn't be surprised if the fuzzer can do something surprising with the new testcase here - may need to disallow it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants