mapped sounds from 26.1 back through 1.19.4#102
Open
mfishma wants to merge 4 commits intoViaVersion:mainfrom
Open
mapped sounds from 26.1 back through 1.19.4#102mfishma wants to merge 4 commits intoViaVersion:mainfrom
mfishma wants to merge 4 commits intoViaVersion:mainfrom
Conversation
used https://pokechu22.github.io/BurgerWebViewer to sanity check existence of sounds in each version, but this still needs to be tested.
Member
|
See the failing test |
parrot.imitate.camel_husk fixed
kennytv
reviewed
Mar 12, 2026
| "entity.ghastling.ambient": "entity.ghast.ambient", | ||
| "entity.ghastling.death": "entity.ghast.death", | ||
| "entity.ghastling.hurt": "entity.ghast.hurt", | ||
| "entity.ghastling.spawn": "entity.ghast.scream", |
Member
There was a problem hiding this comment.
This one seems a bit aggressive
Author
There was a problem hiding this comment.
Good point — I was just thinking about easy parity, but those hurt screams can be pretty intense. I switched the hurt sound to ambient; even though they already make ambient noises, it still works. The scream sound file is affectionate_scream, a small yelp triggered when a dried_ghast becomes a ghastling. We could stick with another ghast.ambient mapping or try block.chorus_flower.grow, which doesn’t quite match but is a crunchy sound of something growing. Your call.
Switched hurt and death sounds of ghast family and nautiluseses.
Author
|
Ready for re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using https://pokechu22.github.io/BurgerWebViewer to sanity-check the existence of sounds in each version, I mapped most items, leaving out ones that didn't make sense, and adhering to the mapping, in that, a fall sound stays a fall sound, a break sound maps to a break sound, etc.
Of note: