Skip to content

Comments

wip: uipath-platform#95

Open
radu-mocanu wants to merge 2 commits intomainfrom
feat/uipath-platform
Open

wip: uipath-platform#95
radu-mocanu wants to merge 2 commits intomainfrom
feat/uipath-platform

Conversation

@radu-mocanu
Copy link
Collaborator

@radu-mocanu radu-mocanu commented Feb 20, 2026

  • import triggers from uipath-core

ToDo:

  • remove dev version

Development Package

  • Add this package as a dependency in your pyproject.toml:
[project]
dependencies = [
  # Exact version:
  "uipath-runtime==0.9.0.dev1000950339",

  # Any version from PR
  "uipath-runtime>=0.9.0.dev1000950000,<0.9.0.dev1000960000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath-runtime = { index = "testpypi" }

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors trigger types from the uipath-runtime package to the uipath-core package, establishing shared types across UiPath Python packages. The change updates the dependency on uipath-core to a development version (0.5.1.dev1000450222) from test PyPI that contains the newly moved trigger types.

Changes:

  • Removed src/uipath/runtime/resumable/trigger.py containing trigger type definitions
  • Updated all imports to use from uipath.core.triggers import instead of local imports
  • Updated dependency specification to pin to dev version from test PyPI
  • Removed trigger type exports from uipath-runtime public API

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
uv.lock Updated uipath-core dependency to version 0.5.1.dev1000450222 from test PyPI
tests/test_resumable.py Changed imports to use uipath.core.triggers
tests/test_chat.py Changed imports to use uipath.core.triggers
src/uipath/runtime/resumable/trigger.py Deleted file - trigger types moved to uipath-core
src/uipath/runtime/resumable/runtime.py Updated imports to use uipath.core.triggers
src/uipath/runtime/resumable/protocols.py Updated imports to use uipath.core.triggers
src/uipath/runtime/resumable/init.py Removed trigger type exports from module
src/uipath/runtime/result.py Updated imports to use uipath.core.triggers
src/uipath/runtime/debug/runtime.py Updated imports to use uipath.core.triggers
src/uipath/runtime/chat/runtime.py Updated imports to use uipath.core.triggers
src/uipath/runtime/chat/protocol.py Updated imports to use uipath.core.triggers
src/uipath/runtime/init.py Removed trigger type exports from public API
pyproject.toml Pinned uipath-core to dev version and configured test PyPI source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pyproject.toml Outdated
requires-python = ">=3.11"
dependencies = [
"uipath-core>=0.5.0, <0.6.0",
"uipath-core==0.5.1.dev1000450222",
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency is pinned to a specific dev version from test PyPI. This is appropriate for WIP/testing but should not be merged to production. Before merging, this should be updated to use a stable version range (e.g., ">=0.5.1,<0.6.0") from the production PyPI index.

Suggested change
"uipath-core==0.5.1.dev1000450222",
"uipath-core>=0.5.1,<0.6.0",

Copilot uses AI. Check for mistakes.
Comment on lines 10 to 15
__all__ = [
"UiPathResumableStorageProtocol",
"UiPathResumeTriggerCreatorProtocol",
"UiPathResumeTriggerReaderProtocol",
"UiPathResumeTriggerProtocol",
"UiPathResumeTrigger",
"UiPathResumeTriggerType",
"UiPathApiTrigger",
]
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a breaking API change. The types UiPathResumeTrigger, UiPathResumeTriggerType, UiPathApiTrigger, and UiPathResumeTriggerName were previously exported from uipath.runtime and are now removed. Users importing these types from uipath.runtime will experience import errors. Consider either: (1) re-exporting these types from uipath.runtime for backward compatibility, or (2) documenting this as a breaking change with migration instructions in the release notes.

Copilot uses AI. Check for mistakes.
Comment on lines +109 to +111

[tool.uv.sources]
uipath-core = { index = "testpypi" }
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuring uipath-core to use test PyPI is appropriate for WIP/testing but should be removed before merging to production. Production releases should use packages from the official PyPI index.

Suggested change
[tool.uv.sources]
uipath-core = { index = "testpypi" }

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant