refactor: remove evalSetRun status update logic #1185
+1
−386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all code that updates the status of evalSetRun entities. This includes: - Removed UPDATE_EVAL_SET_RUN event publishing from _runtime.py - Removed update_eval_set_run() and _update_eval_set_run_spec() methods from _progress_reporter.py - Removed _on_eval_set_run_updated() method from _telemetry.py - Removed handle_update_eval_set_run() method from _console_progress_reporter.py - Removed event subscriptions for UPDATE_EVAL_SET_RUN across all subscribers - Removed related test cases from test_progress_reporter.py and test_eval_telemetry.py The evalSetRun status will no longer be updated in StudioWeb backend or tracked in telemetry. All tests pass successfully (1,791 tests with 98% coverage in eval module). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions
bot
added
test:uipath-langchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all code logic that updates the status of
evalSetRunentities, as requested.Changes Made
UPDATE_EVAL_SET_RUNevent publishing (success and failure cases)update_eval_set_run(),_update_eval_set_run_spec(), andhandle_update_eval_set_run()methods_on_eval_set_run_updated()telemetry tracking methodhandle_update_eval_set_run()console reporting methodUPDATE_EVAL_SET_RUNevent subscriptions across subscribersImpact
Testing
✅ All tests pass successfully:
Files Changed
src/uipath/_cli/_evals/_runtime.pysrc/uipath/_cli/_evals/_progress_reporter.pysrc/uipath/_cli/_evals/_telemetry.pysrc/uipath/_cli/_evals/_console_progress_reporter.pytests/cli/eval/test_progress_reporter.pytests/cli/eval/test_eval_telemetry.pyTotal: 6 files changed, 1 insertion(+), 386 deletions(-)
🤖 Generated with Claude Code