Skip to content

Conversation

@alexandrujircan
Copy link
Collaborator

Some parameters of the start extraction / classification validation request are actually optional, with default values embedded in the framework: https://github.com/UiPath/DU-App/blob/b8b7e29cc047b16c205dac6de3864f037484d5e8/src/framework/UiPath.DocumentUnderstanding.Framework.Api/Controllers/Model/Validation/StartValidationTaskRequest.cs#L55

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes action parameters optional in the Documents service by adding default values (None) to parameters used in extraction and classification validation requests. This aligns with the framework's default behavior where these parameters are not required.

Changes:

  • Made action-related parameters (priority, catalog, folder, storage bucket) optional with None defaults
  • Reordered function parameters to place required arguments before optional ones
  • Added comprehensive test coverage for the new optional parameter behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/uipath/platform/documents/_documents_service.py Updated method signatures to make action parameters optional and reordered parameters to follow Python conventions
tests/sdk/services/test_documents_service.py Added three new test cases verifying correct behavior when optional parameters are omitted

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants