Merged
Conversation
Contributor
|
Hi @kafitzgerald, Thanks for this fix. IMO, testing/metadata etc. you mention could be done in a follow-up. All tests for this so I okay approving this and cutting a new release. |
rajeeja
approved these changes
Jan 7, 2026
erogluorhan
approved these changes
Jan 7, 2026
Member
erogluorhan
left a comment
erogluorhan
left a comment
There was a problem hiding this comment.
Thanks for this! Please feel free to work on the remaining changes you mentioned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1434
To fully close this issue we should probably add testing and explicit support for Python 3.14 (i.e. metadata, etc.). I'm happy to make those changes as well, if that's of interest at this point.
Overview
Updates the NumPy version pin to <2.4 now that Numba supports NumPy 2.3.
PR Checklist
General