Operation/adding error manager implementaton #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-command into application/untested-telemetry-collection-and-watchdog-tasks
Contributor
TheDopplerEffects
left a comment
TheDopplerEffects
left a comment
There was a problem hiding this comment.
- Quite a few files were missed
- Mana cases of if statements missing block quotes I.e.
if (error)
reportError;
return error; // this line should be skipped when error = 0 but is run anyway because it is not in {}
- Files such as RI2c.c are missing.
Please double-check your repo.
Comment on lines
+317
to
+321
| <<<<<<< HEAD | ||
| // transmit WDOG pet to transmitter module | ||
| ======= | ||
| // transmit WDOG reset_t to transmitter module | ||
| >>>>>>> aa164ee08d0f9195d610920edab623484dec5094 |
Contributor
There was a problem hiding this comment.
This is the remnants of a failed Merge that didn't get resolved.
Comment on lines
+307
to
+311
| <<<<<<< HEAD | ||
| // transmit WDOG pet to receiver module | ||
| ======= | ||
| // transmit WDOG reset_t to receiver module | ||
| >>>>>>> aa164ee08d0f9195d610920edab623484dec5094 |
Contributor
There was a problem hiding this comment.
This is the remnants of a failed Merge that didn't get resolved.
Comment on lines
+72
to
+74
| if (error != SUCCESS) | ||
| errorReportModule(moduleFram , error); | ||
| return error; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (error != SUCCESS) | |
| errorReportModule(moduleFram , error); | |
| return error; | |
| if (error != SUCCESS) { | |
| errorReportModule(moduleFram , error); | |
| return error; | |
| } |
Comment on lines
+67
to
+69
| if (error != SUCCESS) | ||
| errorReportModule(moduleFram , error); | ||
| return error; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (error != SUCCESS) | |
| errorReportModule(moduleFram , error); | |
| return error; | |
| if (error != SUCCESS) { | |
| errorReportModule(moduleFram , error); | |
| return error; | |
| } |
Comment on lines
+61
to
+63
| if (error != SUCCESS) | ||
| errorReportModule(moduleFram , error); | ||
| return error; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (error != SUCCESS) | |
| errorReportModule(moduleFram , error); | |
| return error; | |
| if (error != SUCCESS) { | |
| errorReportModule(moduleFram , error); | |
| return error; | |
| } |
|
|
||
| int error = IsisTrxvu_rcGetCommandFrame(TRANSCEIVER_INDEX, &frame); | ||
|
|
||
| // provide the size of the message to the caller |
Contributor
There was a problem hiding this comment.
Missed init and null pointer error. Check hole file
|
|
||
| errorReportComponent(componentTransceiver,error); | ||
|
|
||
| return error; |
Contributor
There was a problem hiding this comment.
Suggested change
| return error; |
Comment on lines
243
to
245
| if (error) | ||
| errorReportComponent(componentTransceiver,error); | ||
| return error; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (error) | |
| errorReportComponent(componentTransceiver,error); | |
| return error; | |
| if (error){ | |
| errorReportComponent(componentTransceiver,error); | |
| return error; | |
| } |
Comment on lines
250
to
252
| if (error) | ||
| errorReportComponent(componentTransceiver,error); | ||
| return error; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (error) | |
| errorReportComponent(componentTransceiver,error); | |
| return error; | |
| if (error) { | |
| errorReportComponent(componentTransceiver,error); | |
| return error; | |
| } |
| errorReportComponent(componentTransceiver,error); | ||
| return error; | ||
|
|
||
| uint16_t uptime = 0; |
Contributor
There was a problem hiding this comment.
Errors missed VVV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation of the error manager, and removed todo's