Skip to content

fix(AnalyticalTable): prevent empty table body flash on first render #8375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 4 commits into from
Mar 25, 2026
+3 −3
Merged

fix(AnalyticalTable): prevent empty table body flash on first render #8375

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8547796
fix(AnalyticalTable): prevent empty table body flash on first render
abzokhattab Mar 23, 2026
62d0fe4
Merge branch 'main' into fix/analytical-table-body-flash
abzokhattab Mar 24, 2026
ea6a419
fix(AnalyticalTable): prevent empty table body flash on first render
abzokhattab Mar 25, 2026
5f545fd
Merge branch 'main' into fix/analytical-table-body-flash
abzokhattab Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/main/src/components/AnalyticalTable/TableBody/VirtualTableBodyContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { enrichEventWithDetails } from '@ui5/webcomponents-react-base';
import { enrichEventWithDetails, useIsomorphicLayoutEffect } from '@ui5/webcomponents-react-base';
import { clsx } from 'clsx';
import type { MutableRefObject } from 'react';
import { useCallback, useEffect, useRef, useState } from 'react';
Expand Down Expand Up @@ -46,9 +46,9 @@ export const VirtualTableBodyContainer = (props: VirtualTableBodyContainerProps)
} = props;
const [isMounted, setIsMounted] = useState(false);

useEffect(() => {
useIsomorphicLayoutEffect(() => {
if (parentRef.current) {
// Trigger one-time re-render after first render -> safe to set state here
// Run before paint so rows appear with the body container (avoids empty-body flash).
// eslint-disable-next-line react-hooks/set-state-in-effect
setIsMounted(true);
}
Expand Down
Loading