Skip to content

selecting models by name when the name contains quotes now works#5703

Closed
gjesse wants to merge 2 commits intoTobikoData:mainfrom
gjesse:selection-w-quotes
Closed

selecting models by name when the name contains quotes now works#5703
gjesse wants to merge 2 commits intoTobikoData:mainfrom
gjesse:selection-w-quotes

Conversation

@gjesse
Copy link
Contributor

@gjesse gjesse commented Feb 17, 2026

Original issue: model selectors that include quoted identifiers (e.g., --select-model "'gcp-project'.dataset.table") would fail to match both the exact selector and wildcard variants, because the selector parser/matcher mishandled the quotes in the model name.

  • Normalized wildcard matching by stripping surrounding identifier quotes on both the selector pattern and model names before fnmatch, allowing mixed quote styles to match consistently (sqlmesh/core/selector.py).
  • Added regression tests covering single-quote, double-quote, and backtick patterns and wildcard matching across quote styles (tests/core/test_selector_quoted_wildcard.py).

@gjesse gjesse force-pushed the selection-w-quotes branch from 8c29a24 to 1b0d59f Compare February 17, 2026 15:49
@vchan vchan closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants