Fix high cyclomatic complexities using Radon#570
Closed
katerinka131 wants to merge 1 commit intoTheKevJames:masterfrom
Closed
Fix high cyclomatic complexities using Radon#570katerinka131 wants to merge 1 commit intoTheKevJames:masterfrom
katerinka131 wants to merge 1 commit intoTheKevJames:masterfrom
Conversation
Owner
|
Thanks for the contribution, but I think adding a bunch of layers of mini-functions can often make code more annoying to read, not less. In the case of the github and CI environment changes, I don't think the new code is materially easier to understand. The CLI entrypoint is slightly cleaner, though the added layers of method indirection make it a bit less understandable at a glance. I also recently refactored that to use typer, so there's lots of merge conflicts there. I'm going to close this as unaccepted for now, but you're certainly welcome to open any changes again if you think that a specific piece is easier for humans to grok! I would just request you keep these changes split apart so we can discuss them individually. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have reduced the cyclomatic complexity in three functions that were marked by Radon as too complex The changes include splitting long functions into smaller ones to improve readability removing redundant conditional statements optimizing logic without changing functionality
This is important because it improves code maintainability and readability simplifies future modifications reduces the risk of errors by minimizing complex branching
Verification was done by rerunning Radon complexity has been reduced