odb: create dbBTerm::getChipBump#9697
odb: create dbBTerm::getChipBump#9697ahmed532 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
To be able to get the dbChipBump from the bterm Signed-off-by: Ahmed R. Mohamed <ahmed@precisioninno.com>
ahmed532
force-pushed
the
feat/odb-dbTerm-dbChipBump
branch
from
a8170a9 to
d12ccd3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new method dbBTerm::getChipBump() to provide a direct way to get the dbChipBump associated with a dbBTerm. This is achieved by adding a back-reference from dbBTerm to dbChipBump, which is populated when dbChipBump::setBTerm is called. The database schema has been updated accordingly. This new method is then used to refactor and simplify the logic in 3dblox.cpp, removing the need for manually building a port-to-bump map. The changes are well-implemented and improve code clarity. I have one minor suggestion to improve code quality.
Note: Security Review did not run due to the size of the PR.
src/odb/src/db/dbBTerm.cpp
Outdated
|
|
||
| dbChipBump* dbBTerm::getChipBump() const | ||
| { | ||
| _dbBTerm* obj = (_dbBTerm*) this; |
There was a problem hiding this comment.
The C-style cast (_dbBTerm*) this within a const method is effectively a const_cast, which is generally unsafe. Since you are only reading from the object, it's safer and clearer to cast to a const pointer, which avoids the const_cast.
const _dbBTerm* obj = (const _dbBTerm*) this;
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Ahmed R. Mohamed <ahmed@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 participant
To be able to get the dbChipBump from the bterm
Closes: #9626