Disable non-actionable, noisy warnings.#9428
Disable non-actionable, noisy warnings.#9428maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
hzeller
commented
Feb 5, 2026
- deprecated: some QString conversions are deprecated, but since they're not addressed now, these warnings might hide other issues.
- unused local typedefs: happens in lemon, but not actionable for us.
* deprecated: some QString conversions are deprecated, but since they're not addressed now, these warnings might hide other issues. * unused local typedefs: happens in lemon, but not actionable for us. Signed-off-by: Henner Zeller <h.zeller@acm.org>
There was a problem hiding this comment.
Code Review
This pull request aims to reduce build noise by disabling two types of compiler warnings and fixing the path matching for suppressing warnings in external dependencies. While the goal is valid, disabling warnings globally can hide issues. My review suggests more targeted approaches for both disabled warnings, either by using pragmas in code for deprecation warnings, or by ensuring third-party dependency warnings are suppressed at the dependency level rather than globally. This will improve long-term maintainability.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Isn't Qt considered an external dependency? Why do we get warnings from it at all? |
|
It is OpenROAD code that uses deprecated functionality. |
|
ready to merge ? |
|
I would like to avoid turning off warnings globally. Lemon is only used in a few places so can we just wrap those includes in a suppression? |
|
The lemon warnings are only a few and I could even live with them, but the hundreds and hundreds of deprecation warnings in the gui (OpenRoad uses QString constants, but they have been deprecated in qt 6 apparently) are annoying and potentially hiding other things. Should I wrap the Qt warnings in |
|
Fight it another day |