Skip to content

Disable non-actionable, noisy warnings.#9428

Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260205-less-warn
Feb 7, 2026
Merged

Disable non-actionable, noisy warnings.#9428
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260205-less-warn

Conversation

@hzeller
Copy link
Collaborator

@hzeller hzeller commented Feb 5, 2026

  • deprecated: some QString conversions are deprecated, but since they're not addressed now, these warnings might hide other issues.
  • unused local typedefs: happens in lemon, but not actionable for us.

 * deprecated: some QString conversions are deprecated,
   but since they're not addressed now, these warnings might
   hide other issues.
 * unused local typedefs: happens in lemon, but not actionable
   for us.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to reduce build noise by disabling two types of compiler warnings and fixing the path matching for suppressing warnings in external dependencies. While the goal is valid, disabling warnings globally can hide issues. My review suggests more targeted approaches for both disabled warnings, either by using pragmas in code for deprecation warnings, or by ensuring third-party dependency warnings are suppressed at the dependency level rather than globally. This will improve long-term maintainability.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

Isn't Qt considered an external dependency? Why do we get warnings from it at all?

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 5, 2026

It is OpenROAD code that uses deprecated functionality.

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 6, 2026

ready to merge ?

@maliberty
Copy link
Member

I would like to avoid turning off warnings globally. Lemon is only used in a few places so can we just wrap those includes in a suppression?

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 6, 2026

The lemon warnings are only a few and I could even live with them, but the hundreds and hundreds of deprecation warnings in the gui (OpenRoad uses QString constants, but they have been deprecated in qt 6 apparently) are annoying and potentially hiding other things.

Should I wrap the Qt warnings in #pragmas that disable that warning ?

@maliberty maliberty merged commit 0386028 into The-OpenROAD-Project:master Feb 7, 2026
13 checks passed
@maliberty
Copy link
Member

Fight it another day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants