Added clock_buffer specification based on string or footprint#9402
Conversation
openroad-ci
commented
Jan 31, 2026
openroad-ci
commented
- added set_cts_config/reset_cts_config -clock_buffer_string -clock_buffer_footprint
- moved BufferUseAnalyser from dbSta to rsz
- replaced sta::PatternMatch with simpler string search
1) added set_cts_config/reset_cts_config -clock_buffer_string -clock_buffer_footprint 2) moved BufferUseAnalyser from dbSta to rsz 3) replaced sta::PatternMatch with simpler string search Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for specifying clock buffers using either a name substring or a cell footprint, which enhances flexibility. The implementation correctly moves the buffer analysis logic to the rsz module and replaces regex matching with a simpler string search. My review focuses on improving documentation consistency, fixing a minor typo in a test file, and refining the implementation logic for better clarity and robustness.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
precisionmoon
requested review from
maliberty
and removed request for
maliberty
|
Does this change default behavior? I'm unclear why metrics needed updating. |
No, this should not. asap7/aes flow test QoR changed a little, starting from the placement step, possibly due to non-determinism or missed test update from previous merge. |
|
//src/cts/test:clock_buffer_footprint-tcl_test failed |
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
