Replace Dictionary.Add #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the function parameter
parametersis sent by reference to every method call. Inside the methods we were using theDictionary.Addmethod in the method body to addphone_numberand other key/value pairs to the theparametersvariable. The problem is that if the key already exists then Dictionary.Add will raise an exception. And sinceparametersis passed by reference the mutation carries over to additional method calls in the same stack which will almost certainly raise an exception unless theparametersinstance is instantiated fresh every time.