Conversation
|
📝 WalkthroughWalkthroughUpdated sponsor blocks in README.md's Partners table. CodeRabbit block now references a new URL and updated image assets. Cloudflare block references updated image assets. Minor formatting and indentation adjustments applied. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 68: Fix the malformed img tag by adding the missing opening quote for the
src attribute so the element becomes valid HTML; update the img element (the
<img ... /> shown in the diff) to use
src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" and verify the
rest of the attributes (height and alt) remain unchanged.
- Around line 64-78: The CodeRabbit light logo img tag is malformed: update the
<img> element that currently reads
src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" to include the
missing opening quote so it becomes
src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg"; verify the
other <img> tags (Cloudflare and dark/light sources) use consistent quoted
src/srcset attributes and correct any similar quoting mistakes (look for the
CodeRabbit <img> element inside the <picture> block).
| <a href="https://www.coderabbit.ai/?via=tanstack&dub_id=aCcEEdAOqqutX6OS" > | ||
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/coderabbit-dark-D643Zkrv.svg" height="40" /> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" /> | ||
| <img src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" /> | ||
| </picture> | ||
| </a> | ||
| </td> | ||
| <td padding="20"> | ||
| <a href="https://www.cloudflare.com?utm_source=tanstack"> | ||
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-DQDB7UaL.svg" height="60" /> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" /> | ||
| <img src="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" alt="Cloudflare" /> | ||
| </picture> | ||
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" /> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" /> | ||
| <img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" /> | ||
| </picture> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify that the new sponsor logo URLs return successful responses.
# Test CodeRabbit logo URLs
echo "Testing CodeRabbit logos..."
curl -I -s "https://tanstack.com/assets/coderabbit-dark-D643Zkrv.svg" | head -n 1
curl -I -s "https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" | head -n 1
# Test Cloudflare logo URLs
echo "Testing Cloudflare logos..."
curl -I -s "https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" | head -n 1
curl -I -s "https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" | head -n 1Repository: TanStack/table
Length of output: 164
Fix malformed image attribute on line 70.
The CodeRabbit light logo img tag is missing the opening quote: <img src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" should be <img src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg". All URLs are publicly accessible, but this syntax error will prevent the image from displaying.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 64 - 78, The CodeRabbit light logo img tag is
malformed: update the <img> element that currently reads
src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" to include the
missing opening quote so it becomes
src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg"; verify the
other <img> tags (Cloudflare and dark/light sources) use consistent quoted
src/srcset attributes and correct any similar quoting mistakes (look for the
CodeRabbit <img> element inside the <picture> block).
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/coderabbit-dark-D643Zkrv.svg" height="40" /> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" /> | ||
| <img src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" /> |
There was a problem hiding this comment.
Critical syntax error: Missing opening quote in src attribute.
The img element's src attribute is missing the opening quote, which will break HTML rendering.
🐛 Proposed fix
- <img src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" />
+ <img src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <img src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" /> | |
| <img src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" /> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 68, Fix the malformed img tag by adding the missing
opening quote for the src attribute so the element becomes valid HTML; update
the img element (the <img ... /> shown in the diff) to use
src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" and verify the
rest of the attributes (height and alt) remain unchanged.
1 participant
🎯 Changes
✅ Checklist
pnpm test:pr.Summary by CodeRabbit