feat(devtools): extract theme to devtool components#173
feat(devtools): extract theme to devtool components#173harry-whorlow wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 028d4b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Do not merge until TanStack/devtools#386 is merged. |
|
View your CI Pipeline Execution ↗ for commit 028d4b8
☁️ Nx Cloud last updated this comment at |
harry-whorlow
changed the title
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughMove the devtools entrypoint to a new components module, adjust dynamic import to load Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/long-corners-repair.md:
- Line 5: Typo in the changeset description: find the exact string "miss-match"
and replace it with the correct spelling "mismatch" in the changeset text;
update the line containing "Moves devtools theme to the component to avoid theme
miss-match." so it reads "Moves devtools theme to the component to avoid theme
mismatch." and save the .changeset entry.
In `@packages/pacer-devtools/src/components/index.tsx`:
- Around line 1-6: Reorder the imports so external packages come before local
modules to satisfy import/order: move the ThemeContextProvider import from
'@tanstack/devtools-ui' above the relative imports (PacerContextProvider and
Shell); keep the type import DevtoolProps where appropriate (it can remain after
external imports or grouped with other external/type imports) and ensure imports
are grouped as: external packages first (e.g., ThemeContextProvider,
DevtoolProps), then local modules (PacerContextProvider, Shell).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ae5129b9-dcf6-4d08-9a9f-40491497f336
📒 Files selected for processing (3)
.changeset/long-corners-repair.mdpackages/pacer-devtools/src/components/index.tsxpackages/pacer-devtools/src/core.tsx
2 participants
Moves devtool theme from the utils to the component to avoid the theme miss-match error we previously had.
Summary by CodeRabbit