Skip to content

Conversation

@crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Dec 1, 2025

Without introducing breaking changes this should fix a ton of issues with SSR

TODO

  • Write initial transform test for core
  • Test Start no JS SSR
  • Test Remix no JS SSR

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

⚠️ No Changeset found

Latest commit: 30a5767

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit 30a5767

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 46s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-30 03:41:36 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1890

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1890

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1890

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1890

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1890

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1890

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1890

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1890

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1890

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1890

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1890

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1890

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1890

commit: 30a5767

@crutchcorn
Copy link
Member Author

crutchcorn commented Dec 1, 2025

List of related issues:

#1611

#1609

#1571

#1260

#1944

@crutchcorn crutchcorn changed the title [WIP] Fix issues with SSR Fix issues with SSR Jan 28, 2026
@sentry
Copy link

sentry bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 75.34247% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.81%. Comparing base (6892ed0) to head (30a5767).
⚠️ Report is 128 commits behind head on main.

Files with missing lines Patch % Lines
packages/form-core/src/utils.ts 60.00% 10 Missing ⚠️
packages/form-core/src/transform.ts 89.47% 2 Missing ⚠️
packages/react-form/src/useForm.tsx 50.00% 2 Missing ⚠️
packages/form-core/src/FormApi.ts 95.45% 1 Missing ⚠️
packages/react-form-nextjs/src/useTransform.ts 0.00% 1 Missing ⚠️
packages/react-form-remix/src/useTransform.ts 0.00% 1 Missing ⚠️
packages/react-form-start/src/useTransform.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
- Coverage   90.35%   89.81%   -0.55%     
==========================================
  Files          38       49      +11     
  Lines        1752     2002     +250     
  Branches      444      506      +62     
==========================================
+ Hits         1583     1798     +215     
- Misses        149      183      +34     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn crutchcorn changed the title Fix issues with SSR [WIP] Fix issues with SSR Jan 28, 2026
@crutchcorn crutchcorn marked this pull request as draft January 28, 2026 02:48
@crutchcorn crutchcorn changed the title [WIP] Fix issues with SSR Fix issues with SSR Jan 30, 2026
@crutchcorn crutchcorn marked this pull request as ready for review January 30, 2026 03:30
# Conflicts:
#	packages/react-form-start/src/createServerValidate.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants