fix(react-db): handle rejected/stale setWindow promises in useLiveInfiniteQuery#1269
Open
sleitor wants to merge 2 commits intoTanStack:mainfrom
Open
fix(react-db): handle rejected/stale setWindow promises in useLiveInfiniteQuery#1269sleitor wants to merge 2 commits intoTanStack:mainfrom
sleitor wants to merge 2 commits intoTanStack:mainfrom
Conversation
…initeQuery Three issues in the useEffect that calls setWindow(): 1. No .catch() — if setWindow rejects, isFetchingNextPage stays true forever with no error surfaced. 2. No cleanup — if the effect re-runs while a previous promise is pending, the stale .then() can set isFetchingNextPage=false prematurely while new loading is in progress. 3. Unhandled promise rejection — the promise has no rejection handler, causing an unhandled rejection warning. Add .catch() with error logging, a cancelled flag with useEffect cleanup to ignore stale promise settlements. Fixes TanStack#1240
🦋 Changeset detectedLatest commit: bc1a705 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
useEffectthat callsutils.setWindow()inuseLiveInfiniteQueryhas three issues:No
.catch()— ifsetWindowrejects (e.g. asyncloadSubsetthrows),isFetchingNextPagestaystrueforever with no error surfaced to the user.No cleanup for stale promises — if the effect re-runs while a previous
setWindowpromise is pending, the old.then()handler fires and setsisFetchingNextPage = falseprematurely while new loading is in progress.Unhandled promise rejection — Node/browser logs an unhandled rejection warning.
Fix
.catch()that resetsisFetchingNextPageand logs the errorcancelledflag withuseEffectcleanup to ignore stale promise settlementsFixes #1240