Skip to content

fix(vite-config): use Node16 module for CJS declaration #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlancollins merged 5 commits into from
Mar 15, 2026
Merged

fix(vite-config): use Node16 module for CJS declaration #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f26e827
fix: upgrade from cjs node10 to node16
birkskyum Mar 14, 2026
b37710f
changeset
birkskyum Mar 14, 2026
8e985b0
Simplify module comment in Vite config
lachlancollins Mar 15, 2026
c1aed96
Change module option from Node16 to NodeNext
lachlancollins Mar 15, 2026
5325427
Update changeset
lachlancollins Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-items-bet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/vite-config': patch
---

fix: declaration resolution where CJS output does not exist for import
4 changes: 2 additions & 2 deletions packages/vite-config/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const tanstackViteConfig = (options: Options): UserConfig => {
exclude: options.exclude,
tsconfigPath: options.tsconfigPath,
compilerOptions: {
module: 99, // ESNext
module: 199, // NodeNext
declarationMap: false,
},
beforeWriteFile: (filePath, content) => {
Expand All @@ -83,7 +83,7 @@ export const tanstackViteConfig = (options: Options): UserConfig => {
exclude: options.exclude,
tsconfigPath: options.tsconfigPath,
compilerOptions: {
module: 1, // CommonJS
module: 199, // NodeNext
declarationMap: false,
},
beforeWriteFile: (filePath, content) => {
Expand Down
Loading