Skip to content

Conversation

@giamir
Copy link
Contributor

@giamir giamir commented Jan 30, 2026

SPARK-167
SPARK-169

This PR addresses a couple of issues in our buttons:

  • Background for selected states was inverted. Now it reflects what is in Figma
  • Selected state of tonal variant was not implemented. Now it also reflects Figma

Before
Screenshot 2026-01-30 at 13 13 06

After
Screenshot 2026-01-30 at 13 12 15
Screenshot 2026-01-30 at 13 13 44

Button docs (PR env)

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

🦋 Changeset detected

Latest commit: 62f72fc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 62f72fc
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/697ca0c85203c4000803b7fe
😎 Deploy Preview https://deploy-preview-2158--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 62f72fc
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/697ca0c8cde6da0008e50160
😎 Deploy Preview https://deploy-preview-2158--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@giamir giamir marked this pull request as ready for review January 30, 2026 12:14
@giamir giamir changed the title fix(button): adjust selected variant styles fix(button): adjust selected state styles Jan 30, 2026
Copy link
Collaborator

@ttaylor-stack ttaylor-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors and orientation match the Figma LGTM. Approved

Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @giamir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants