feat: support copy/pasting tag link nodes in rich text mode#177
Open
feat: support copy/pasting tag link nodes in rich text mode#177
Conversation
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aalear
changed the title
aalear
changed the title
b-kelly
force-pushed
the
bkelly/tag-link-todom
branch
from
858f014 to
cf4b733
Compare
Member
Author
b-kelly
suggested changes
Aug 30, 2022
Contributor
b-kelly
left a comment
b-kelly
left a comment
There was a problem hiding this comment.
TODO needs tests
I'll add these asap so we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses tag link serialization for #56.
The core of the change is switching from NodeView to a schema definition with appropriate toDOM/parseDOM implementations.
It looks like we never wrote tests for the original NodeView nor do we have existing tests for other schema specifications. I'm happy to take a stab at adding some, but for now I left them out.
Also note that pasting from a final rendered document is not currently supported. Part of the issue is that public Q&A still uses
.post-tagrather than.s-tagfrom Stacks. I'm not sure if it's worth adding.post-tagchecks into the editor repo. Feels like we should be moving towards making the Q&A rendering use Stacks classes instead, although that's also a non-trivial undertaking.