Implement merging of AP and LFP channels#1424
Implement merging of AP and LFP channels#1424DradeAW wants to merge 36 commits intoSpikeInterface:mainfrom
Conversation
|
The code is really rough and hard to read, I might break it done into smaller functions but I know that @samuelgarcia doesn't like that very much :) Anyway it's close to being functional. |
|
@alejoe91 @samuelgarcia I think this is about ready, what do you think about it? |
|
@DradeAW we moved to the Could you close this one and open a new one to main? Or we can help to rebase. Let us know! |
DradeAW
force-pushed
the
merge_ap_lfp_neuropix
branch
from
a0925f1 to
ba47792
Compare
…face into merge_ap_lfp_neuropix
|
I think it's done! |
|
@alejoe91 @samuelgarcia Why is the test failing? Other PR don't seem to be failing ... |
|
@DradeAW fixed other tests, now yours are failing ;) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
After a lot of hard work, merging of AP and LFP is working!! The code works, but isn't very pretty as of right now ^^' |
|
@DradeAW: will you have time to work on this in the future? I haven't followed this story at all, but since the merge conflicts mention sorting analyzer I wonder if this will require a lot of work to fix up? Do you want to leave this open? |
|
I can find some time to work on it :) |
3 participants
No description provided.