Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure newly created Solid preferences resources are populated with default triples (and corresponding type index resources are created), instead of leaving the Preferences.ttl document blank.
Changes:
- Add logic in
profileLogic.loadPreferences()to ensure the preferences document exists and (conditionally) initialize default preferences/type-index statements. - Add defaults initialization that inserts
space:ConfigurationFile, a title, and links to public/private type indexes, and creates the index docs if missing. - Update profile logic tests to assert the additional PATCH/PUT requests for populating Preferences.ttl and creating type index files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/profile/profileLogic.ts |
Adds preferences initialization and doc-existence handling during loadPreferences() to populate defaults and create type index docs. |
test/profileLogic.test.ts |
Updates tests to validate PATCH contents for Preferences.ttl and presence of PUTs for preferences/type index resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preference file that was getting created was blank, this populates the file as done in the server upon registration for a new account.