Skip to content

Create a populated pref file#237

Open
SharonStrats wants to merge 11 commits intomainfrom
fix/pref-file-creation
Open

Create a populated pref file#237
SharonStrats wants to merge 11 commits intomainfrom
fix/pref-file-creation

Conversation

@SharonStrats
Copy link
Copy Markdown

The preference file that was getting created was blank, this populates the file as done in the server upon registration for a new account.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to ensure newly created Solid preferences resources are populated with default triples (and corresponding type index resources are created), instead of leaving the Preferences.ttl document blank.

Changes:

  • Add logic in profileLogic.loadPreferences() to ensure the preferences document exists and (conditionally) initialize default preferences/type-index statements.
  • Add defaults initialization that inserts space:ConfigurationFile, a title, and links to public/private type indexes, and creates the index docs if missing.
  • Update profile logic tests to assert the additional PATCH/PUT requests for populating Preferences.ttl and creating type index files.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/profile/profileLogic.ts Adds preferences initialization and doc-existence handling during loadPreferences() to populate defaults and create type index docs.
test/profileLogic.test.ts Updates tests to validate PATCH contents for Preferences.ttl and presence of PUTs for preferences/type index resources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants