fix(types): auto-generate strict types from OpenAPI schema #467
+994
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
force-pushed
the
fix/generate-strict-types-from-openapi
branch
7 times, most recently
from
6bfd0fc to
f4fa812
Compare
billxinli
reviewed
Jan 22, 2026
billxinli
approved these changes
Jan 22, 2026
Contributor
billxinli
left a comment
billxinli
left a comment
There was a problem hiding this comment.
Left a question regarding required values from the Open api spec file.
jdalton
force-pushed
the
fix/generate-strict-types-from-openapi
branch
from
f40d313 to
bc31734
Compare
billxinli
approved these changes
Jan 22, 2026
jdalton
force-pushed
the
fix/generate-strict-types-from-openapi
branch
6 times, most recently
from
dceea49 to
4dc81f1
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jdalton
force-pushed
the
fix/generate-strict-types-from-openapi
branch
2 times, most recently
from
20df300 to
0569051
Compare
- Add scripts/generate-strict-types.mjs to generate src/types-strict.ts from openapi.json instead of manual maintenance - Update generate-sdk.mjs to run strict type generation after API types - RepositoryItem now includes missing fields: slug, description, head_full_scan_id, integration_meta, workspace, slig - ListRepositoriesOptions now includes include_archived - Remove organization_id/organization_slug (not in API response) - Types stay in sync automatically when OpenAPI changes Fixes SMO-573
jdalton
force-pushed
the
fix/generate-strict-types-from-openapi
branch
from
0569051 to
3a628b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scripts/generate-strict-types.mjsto auto-generatesrc/types-strict.tsfromopenapi.jsongenerate-sdk.mjsto include strict type generation in the workflowRepositoryItem changes
Added (previously missing):
slug- Repository slugdescription- Repository descriptionhead_full_scan_id- ID of the head full scanintegration_meta- GitHub integration metadata (now properly nullable)workspace- Repository workspaceslig- Legacy typo field for backwards compatibilityRemoved (not in API response):
organization_idorganization_slugListRepositoriesOptions changes
Added:
include_archived- Filter to include archived repositoriesTest plan
pnpm run generate-sdkworkflow works end-to-end