-
-
Notifications
You must be signed in to change notification settings - Fork 223
Detect and use tracker PID during HID enumeration #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Using tracker's HID directly should be an optional feature. Normally, the job of the server is to pair tracker to the dongle when it's connected, and nothing else. If it will also process data, it will confuse the user since the tracker will be automatically connected, but might not be paired to the dongle... It needs to be behind a developer option. |
|
I think the toggle will likely need to be on the tracker itself (and disabled by default) since having this feature enabled will prevent it from entering pairing automatically. I think it is okay to always detect on the server, as there is currently no way for the server to tell the tracker it is receiving data through the USB connection. |
|
I think a global setting is better, you can make server accept or not accept connections from this device id if it's enable or disabled. Either way, it should be implemented before it's merged, in whichever way you prefer. Otherwise it breaks intended workflow. |
|
Okay, I will still probably need to give trackers a toggle in the meantime |
|
Whats the status on this @sctanf? why is it still a draft |
|
while it works, it was going to be changed to be on a toggle instead, ie. to not potentially cause confusion on why a tracker may only work while plugged into the computer |
1 similar comment
|
while it works, it was going to be changed to be on a toggle instead, ie. to not potentially cause confusion on why a tracker may only work while plugged into the computer |
9155c1e to
dfd0a3a
Compare
8ea3174 to
b4e0fac
Compare
23dfa54 to
b403d82
Compare

SlimeVR/SolarXR-Protocol#190
#1548