Update shared infra and fix styles#387
Conversation
|
We'll need to fix the build on main first (by copying some build config from ImageSharp) |
And this project was still on net6 |
* removed the configure method. thats only syntactic sugar and aot is not happy with that method
|
I have updated this lib to .net8 and .net9. I had to fix some issues which were reported. The configure method was complaining multiple things because of aot. Because this is just a lil bit of syntactic sugar i went with deleting it |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
===================================
Coverage 85% 86%
===================================
Files 82 83 +1
Lines 2361 2397 +36
Branches 356 365 +9
===================================
+ Hits 2023 2063 +40
+ Misses 232 224 -8
- Partials 106 110 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon. |
I was not happy about that dynamicaccessedattributes either. Those are probably from enabled aot. We could also go the way of removing them and add istrimmable = false. |
|
I updated this branch. It's still to be discussed wether to disable trimming support or keep the added attributes |
No description provided.