This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Fix for issue #672#674
Open
DeanCording wants to merge 1 commit intoShopify:masterfrom
DeanCording:patch-1
Open
Fix for issue #672#674DeanCording wants to merge 1 commit intoShopify:masterfrom DeanCording:patch-1
DeanCording wants to merge 1 commit intoShopify:masterfrom
DeanCording:patch-1
Conversation
Any widget that uses Dashing.AnimatedValue will lock up if sent current and last values which are the same but different object types ie. current = '5' and last = 5. Problem is due to CoffeeScript translating == comparison on line 78 into a === comparison, which fails when given different object types. As the num and to values are the same, the increment is zero. The timer termination test only checked if the num value had passed the to value, which it would never do if increment is zero. The fix adds a test if the num and to values are equal so that the timer runs once but then terminates.
Author
|
Same change as proposed in #618 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any widget that uses Dashing.AnimatedValue will lock up if sent current and last values which are the same but different object types ie. current = '5' and last = 5.
Problem is due to CoffeeScript translating == comparison on line 78 into a === comparison, which fails when given different object types. As the num and to values are the same, the increment is zero. The timer termination test only checked if the num value had passed the to value, which it would never do if increment is zero. The fix adds a test if the num and to values are equal so that the timer runs once but then terminates.