This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Add y-axis log scale to the graph widget#513
Open
ke4roh wants to merge 2 commits intoShopify:masterfrom
Open
Conversation
Contributor
|
Are there any breaking changes in the upgrade of rickshaw? Does this commit integrate with #542? |
Author
|
I've been running it for 3 months and haven't noticed any changes (aside from it working) with the upgrade to Rickshaw. It will not play well with #542 because it references an even newer version of d3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this graph widget, it's now trivial to get a log-scale y-axis.
data-yscale="log"or, instead of "log", "linear", or specify the base, e.g.log(2),log(e), orlog(10).This also upgrades d3 and rickshaw to the latest.