Get the view path of a widget on IE#322
Conversation
Replace constructor.name with a new function called getName that works on Internet Explorer. This new function is based on this workaround to support Function.name: http://matt.scharley.me/2012/03/09/monkey-patch-name-ie.html Combined with PR Shopify#310, the library works fine on IE. Disclaimer: I do not use Internet Explorer! However, I developed a TV panel using your library, and now we have to support IE...
|
Thanks for this. I note that this same fix is used in the dashing.coffee in the node.js port of dashing, which works much better with IE. |
|
Hello, i'm trying to use dashing with the fixes for the IE and i'm not getting nothing. I tried in IE9, IE10 and IE11. I even cloned the repo of bielfrontera and liquidcc but nothing. Can you help? |
|
Rafael, Have you installed node.js and the event-source code? It wasn't working for me until I installed those things. |
|
Hi Rafael, Sorry for the delayed response. I moved over to dashing-js, a On Thu, Jun 12, 2014 at 12:34 AM, Rafael Escrich notifications@github.com
|
|
Based on @rafaelescrich's comment, can someone confirm if this PR works in IE and if so, what versions? Otherwise, no breaking changes and this seems like a desirable feature. Even if IE is lame. |
|
Just found #310 -- seems like that PR is a better candidate as it includes these fixes as well as other changes. |
Replace constructor.name with a new function called getName that works on Internet Explorer.
This new function is based on this workaround to support Function.name: http://matt.scharley.me/2012/03/09/monkey-patch-name-ie.html
Combined with PR #310, the library works fine on IE.
Disclaimer: I do not use Internet Explorer! However, I developed a TV panel using your library, and now we have to support IE...