This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Add route to persist history.yml on demand#268
Open
andyhayes wants to merge 1 commit intoShopify:masterfrom
Open
Add route to persist history.yml on demand#268andyhayes wants to merge 1 commit intoShopify:masterfrom
andyhayes wants to merge 1 commit intoShopify:masterfrom
Conversation
|
This sounds really really really GREAT ! |
|
This sounds like a great idea, I will add this API to dashing-contrib |
Contributor
|
This is a cool idea, though it might be nicer to simply persist the history whenever Lines 133 to 139 in 439182f This depends on how expensive it is to write the history to disk... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for issue #244 (
history.ymlfile not being written when server not shut down cleanly) but probably useful in other scenarios too.Adds
post /system/persist-historyroute to persist thehistory.ymlfile to disk on demand. As with other routes, it requires a json body with valid auth_token.Not 100% sure on the route path, so happy to change if anyone has a better suggestion.