On app selection keep retrying when failing but avoid capturing unrelated errors

[alfonso-noriega]

WHY are these changes introduced?

Vault Error

GH Issue #15725

Observe link

The app selection logic contained redundant error handling and retry mechanisms that were making the code unnecessarily complex and potentially masking actual issues during the selection process.

WHAT is this pull request doing?

• Removes redundant error checking in selectAppPrompt function that was checking for null after using the non-null assertion operator
• Simplifies the retry logic in selectOrCreateApp by removing try-catch blocks and letting natural control flow handle retries
• Updates error message from "interrupted" to "failed" to better reflect the actual failure condition
• Streamlines the app selection flow while maintaining the same retry behavior

How to test your changes?

1. Run shopify app dev in a project directory
2. Go through the app selection prompt
3. Verify that app selection works normally
4. Test edge cases where app selection might fail to ensure retry logic still functions
5. Confirm error messages are clear and helpful when selection ultimately fails

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[alfonso-noriega]

• On app selection keep retrying when failing but avoid capturing unrelated errors #6904 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	78.86%	14521/18414
🟡	Branches	73.17%	7225/9874
🟡	Functions	79.04%	3691/4670
🟡	Lines	79.2%	13727/17331

Test suite run success

3788 tests passing in 1448 suites.

Report generated by 🧪jest coverage report action from f3d32ce

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[binks-code-reviewer]

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - No issues

📋 History

✅ 2 findings → ✅ No issues → ✅ No issues → ✅ No issues → ✅ No issues → ✅ No issues

[isaacroldan]

Let's remove the ! and handle the undefined selected app outside