Skip to content

Replace hosted_app_home build mode with copy_files mode#6868

Open
alfonso-noriega wants to merge 1 commit into02-wire-build-config-into-extension-specsfrom
03-hosted-static-app-build-pipeline
Open

Replace hosted_app_home build mode with copy_files mode#6868
alfonso-noriega wants to merge 1 commit into02-wire-build-config-into-extension-specsfrom
03-hosted-static-app-build-pipeline

Conversation

@alfonso-noriega
Copy link
Contributor

@alfonso-noriega alfonso-noriega commented Feb 19, 2026

WHY are these changes introduced?

Fixes https://github.com/shop/issues-admin-extensibility/issues/2240

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

alfonso-noriega commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alfonso-noriega alfonso-noriega changed the title Abstract build steps to externalize the build configuration Replace hosted_app_home build mode with copy_files mode Feb 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.92% 14626/18533
🟡 Branches 73.18% 7270/9935
🟡 Functions 79.13% 3711/4690
🟡 Lines 79.27% 13831/17448

Test suite run success

3850 tests passing in 1491 suites.

Report generated by 🧪jest coverage report action from f042eff

@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from 98aebcd to 802c958 Compare February 19, 2026 13:05
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 1c5c718 to 3ac919f Compare February 19, 2026 13:05
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from 802c958 to b311dcc Compare February 19, 2026 13:05
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from 2b6f7ba to 68c2a9f Compare February 19, 2026 13:20
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch 2 times, most recently from db26c65 to ec9b8bf Compare February 19, 2026 13:27
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 68c2a9f to 8096aa6 Compare February 19, 2026 13:27
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from ec9b8bf to 973438a Compare February 19, 2026 13:36
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from f6ae0a0 to 1b503e0 Compare February 19, 2026 13:53
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch 2 times, most recently from 71f4c4d to c12d17e Compare February 19, 2026 14:20
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 1b503e0 to 01cfc8b Compare February 19, 2026 14:20
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch 2 times, most recently from da8c9c5 to c168755 Compare February 19, 2026 14:33
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from 048e70a to c25acc0 Compare February 19, 2026 15:31
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from c168755 to 146db7f Compare February 19, 2026 15:31
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from 146db7f to e56e3c3 Compare February 20, 2026 10:38
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from c25acc0 to 7e39fc5 Compare February 20, 2026 10:38
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from e56e3c3 to ed19082 Compare February 20, 2026 10:46
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from 0b9bfe1 to 33feefb Compare February 20, 2026 12:29
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch 2 times, most recently from d5a9a3f to c356f95 Compare February 20, 2026 12:36
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 33feefb to 4dd6917 Compare February 20, 2026 12:36
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from c356f95 to d0d8bed Compare February 20, 2026 12:51
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 4dd6917 to 56f0d4a Compare February 20, 2026 12:51
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch 2 times, most recently from 61f38e1 to 7ea9b07 Compare February 20, 2026 13:45
@alfonso-noriega alfonso-noriega marked this pull request as ready for review February 20, 2026 14:04
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner February 20, 2026 14:04
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from 7ea9b07 to ea8da6c Compare February 20, 2026 15:00
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 56f0d4a to cfe3768 Compare February 20, 2026 15:00
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from ea8da6c to b87689a Compare February 24, 2026 12:43
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from d802f80 to 85cabf0 Compare February 25, 2026 16:39
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from b87689a to c7bb834 Compare February 25, 2026 16:39
@alfonso-noriega alfonso-noriega force-pushed the 03-hosted-static-app-build-pipeline branch from c7bb834 to f042eff Compare February 27, 2026 11:33
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 85cabf0 to 61f4d35 Compare February 27, 2026 11:33
interface BuildConfig {
mode: 'ui' | 'theme' | 'function' | 'tax_calculation' | 'copy_files' | 'none'
steps: ReadonlyArray<BuildStep>
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildConfig is now a breaking change: mode: 'none' requires steps

Previously BuildConfig was a union where {mode: 'none'} did not include steps. This PR changes it to an interface with mandatory steps for all modes, including none. Existing specs or runtime payloads that omit steps for none will fail type-checking or force dummy steps: [] everywhere.

Evidence: helper defaults updated to {mode: 'none', steps: []} only fixes callers using helpers; other constructors/deserializers remain broken.

Impact: TS compile failures and downstream breakage; may block builds/releases; affects any extension spec using {mode:'none'} without steps.

@binks-code-reviewer
Copy link

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - 1 findings

📋 History

✅ 1 findings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant