Replace hosted_app_home build mode with copy_files mode#6868
Replace hosted_app_home build mode with copy_files mode#6868alfonso-noriega wants to merge 1 commit into02-wire-build-config-into-extension-specsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success3850 tests passing in 1491 suites. Report generated by 🧪jest coverage report action from f042eff |
98aebcd to
802c958
Compare
1c5c718 to
3ac919f
Compare
802c958 to
b311dcc
Compare
2b6f7ba to
68c2a9f
Compare
db26c65 to
ec9b8bf
Compare
68c2a9f to
8096aa6
Compare
ec9b8bf to
973438a
Compare
f6ae0a0 to
1b503e0
Compare
71f4c4d to
c12d17e
Compare
1b503e0 to
01cfc8b
Compare
da8c9c5 to
c168755
Compare
048e70a to
c25acc0
Compare
c168755 to
146db7f
Compare
146db7f to
e56e3c3
Compare
c25acc0 to
7e39fc5
Compare
e56e3c3 to
ed19082
Compare
0b9bfe1 to
33feefb
Compare
d5a9a3f to
c356f95
Compare
33feefb to
4dd6917
Compare
c356f95 to
d0d8bed
Compare
4dd6917 to
56f0d4a
Compare
61f38e1 to
7ea9b07
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
7ea9b07 to
ea8da6c
Compare
56f0d4a to
cfe3768
Compare
ea8da6c to
b87689a
Compare
d802f80 to
85cabf0
Compare
b87689a to
c7bb834
Compare
c7bb834 to
f042eff
Compare
85cabf0 to
61f4d35
Compare
| interface BuildConfig { | ||
| mode: 'ui' | 'theme' | 'function' | 'tax_calculation' | 'copy_files' | 'none' | ||
| steps: ReadonlyArray<BuildStep> | ||
| } |
There was a problem hiding this comment.
BuildConfig is now a breaking change: mode: 'none' requires steps
Previously BuildConfig was a union where {mode: 'none'} did not include steps. This PR changes it to an interface with mandatory steps for all modes, including none. Existing specs or runtime payloads that omit steps for none will fail type-checking or force dummy steps: [] everywhere.
Evidence: helper defaults updated to {mode: 'none', steps: []} only fixes callers using helpers; other constructors/deserializers remain broken.
Impact: TS compile failures and downstream breakage; may block builds/releases; affects any extension spec using {mode:'none'} without steps.
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 1 findings 📋 History✅ 1 findings |

WHY are these changes introduced?
Fixes https://github.com/shop/issues-admin-extensibility/issues/2240
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist