make remote dev console the default case #6797
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -6,7 +6,7 @@ export declare const environmentVariables: {
enableCliRedirect: string;
env: string;
firstPartyDev: string;
- skipLocalDevConsole: string;
+ useLocalDevConsole: string;
noAnalytics: string;
partnersToken: string;
runAsUser: string;
packages/cli-kit/dist/public/node/context/local.d.ts@@ -71,12 +71,13 @@ export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
*/
export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
/**
- * Returns true if the local dev console should be skipped.
+ * Returns true if the local dev console should be used.
+ * This is an opt-in flag for 1P developers to use the local dev console.
*
* @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_SKIP_LOCAL_DEV_CONSOLE is truthy.
+ * @returns True if SHOPIFY_USE_LOCAL_DEV_CONSOLE is truthy.
*/
-export declare function skipLocalDevConsole(env?: NodeJS.ProcessEnv): boolean;
+export declare function useLocalDevConsole(env?: NodeJS.ProcessEnv): boolean;
/**
* Return gitpodURL if we are running in gitpod.
* Https://www.gitpod.io/docs/environment-variables#default-environment-variables.
|
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3689 tests passing in 1431 suites. Report generated by 🧪jest coverage report action from 0c53ab1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Addresses https://github.com/shop/issues-develop/issues/21458
Makes remote dev console the default, allowing 1p devs to opt-out via flag if necessary.
WHAT is this pull request doing?
Replaces the optional skip logic with opt-in logic for the local dev console.
How to test your changes?
SHOPIFY_USE_LOCAL_DEV_CONSOLE=1 pnpm shopify app devPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist