Skip to content

refactor: use directional isolation instead of locale RTL label#562

Merged
Samillion merged 3 commits intomainfrom
directional_isolation
Mar 19, 2026
Merged

refactor: use directional isolation instead of locale RTL label#562
Samillion merged 3 commits intomainfrom
directional_isolation

Conversation

@Samillion
Copy link
Copy Markdown
Owner

@Samillion Samillion commented Mar 19, 2026

Changes:

  • Use directional isolation to show RTL locale tooltips correctly instead of setting direction into each locale set
    • Replaces relying on \fe-1 as it is generally not recommended.
  • Remove lang_direction from all locales
  • Remove lang_direction from locale docs

Reference: https://www.unicode.org/reports/tr9/#Explicit_Directional_Isolates

image

Based on: mpv-player/mpv#17606

Their implementation requires more consideration (ie: native context menu). However, for this use case just for tooltips, it should suffice.

@Samillion Samillion merged commit ff83a46 into main Mar 19, 2026
@Samillion Samillion deleted the directional_isolation branch March 19, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant