Skip to content

Conversation

@minggangw
Copy link
Member

@minggangw minggangw commented Jan 16, 2026

This pull request updates file system operations to improve compatibility with Electron's ASAR packaging system by replacing fs.access() with fs.stat() for existence checks. This is important since the project explicitly targets Electron (as seen in package.json with --target [email protected]).

Changes:

  • Replaced fs.access() with fs.stat() in the findPackagesInDirectory function
  • Replaced fsPromises.access() with fsPromises.stat() in the pathExists utility function

Fix: #1375

Copilot AI review requested due to automatic review settings January 16, 2026 05:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates file system operations to improve compatibility with Electron's ASAR packaging system by replacing fs.access() with fs.stat() for existence checks. This is important since the project explicitly targets Electron (as seen in package.json with --target [email protected]).

Changes:

  • Replaced fs.access() with fs.stat() in the findPackagesInDirectory function
  • Replaced fsPromises.access() with fsPromises.stat() in the pathExists utility function

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
rosidl_gen/packages.js Updated directory existence check for 'share' folder to use fs.stat() instead of fs.access()
lib/utils.js Updated pathExists() utility function to use fsPromises.stat() instead of fsPromises.access()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

Coverage Status

coverage: 85.544% (+0.02%) from 85.524%
when pulling 68455b6 on minggangw:fix-1374
into 7767051 on RobotWebTools:develop.

@minggangw minggangw merged commit a45c45a into RobotWebTools:develop Jan 16, 2026
18 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants