Don't run test for rolling on Windows temporarily#1103
Merged
minggangw merged 1 commit intoRobotWebTools:developfrom Apr 24, 2025
Merged
Don't run test for rolling on Windows temporarily#1103minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw merged 1 commit intoRobotWebTools:developfrom
Conversation
The latest ROS2 rolling is migrating to `pixi` to install dependencies on Windows platform, which causes the failure of running unit tests, we are going to disable it temporarily. See details: - https://docs.ros.org/en/rolling/Installation/Windows-Install-Binary.html - RobotWebTools#1101 Fix: RobotWebTools#1102
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables the Windows unit tests for the ROS2 rolling distribution to address dependency issues.
- Updated workflow file to add an extra condition excluding the rolling distro from running tests.
- Adjusted command conditions in the Windows build-and-test workflow to avoid failures on Windows installations using ROS2 rolling.
| call "c:\dev\${{ needs.identify-ros-distro.outputs.distro }}\ros2-windows\setup.bat" | ||
| cmd /c "if ${{ needs.identify-ros-distro.outputs.distro }}==foxy (set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp&&npm test)" | ||
| cmd /c "if NOT ${{ needs.identify-ros-distro.outputs.distro }}==foxy (npm test)" | ||
| cmd /c "if NOT ${{ needs.identify-ros-distro.outputs.distro }}==foxy if NOT ${{ needs.identify-ros-distro.outputs.distro }}==rolling (npm test)" |
There was a problem hiding this comment.
The consecutive 'if NOT' conditions on a single line may lead to ambiguity in command execution. Consider refactoring the command using proper grouping or nested conditions to clearly enforce both checks.
Suggested change
| cmd /c "if NOT ${{ needs.identify-ros-distro.outputs.distro }}==foxy if NOT ${{ needs.identify-ros-distro.outputs.distro }}==rolling (npm test)" | |
| cmd /c "if NOT ${{ needs.identify-ros-distro.outputs.distro }}==foxy (if NOT ${{ needs.identify-ros-distro.outputs.distro }}==rolling (npm test))" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest ROS2 rolling is migrating to
pixito install dependencies on Windows platform, which causes the failure of running unit tests, we are going to disable it temporarily.See details:
Fix: #1102