Open
Conversation
1.1 Aligned package versions with respective targets (.NET 6, netstandard2.0, .NET 8.0) 1.2 Removed .NET 7.0 target 1.3 Removed direct targets on the library for .NET Framework and only left netstandard2.0 because of dependencies, netstandard2.0 reference required anyways and there is no point to split targets on the library itself. 2. StyleCop is deprecated 2.1 Removed StyleCop 2.2 Added Microsoft.CodeAnalysis.NetAnalyzers 2.3 Fixed nullable references issues and other minor issues 3. Moved packages for unit tests out of .props file 4. Upgraded xUnit 4.1 Fixed xUnit warnings 5. Upgraded the rest of packages in unit tests Signed-off-by: Aliaksandr Kukrash <[email protected]>
github-actions
bot
added
enhancement
…ect settings to .props file Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
… latest .NET version in dotnet-install.sh Signed-off-by: Aliaksandr Kukrash <[email protected]>
Turnerj
requested changes
Jan 14, 2025
Collaborator
Turnerj
left a comment
Turnerj
left a comment
There was a problem hiding this comment.
Hey - appreciate the effort you went to with this PR. I've added some comments.
Signed-off-by: Aliaksandr Kukrash <[email protected]>
…other IDEs and dotnet command line. Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
multiarc
force-pushed
the
feature/net8_support
branch
from
34e1c81 to
e9214e5
Compare
Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added .NET 8 Support
Removed StyleCop.Analyzers in favor of Microsoft.CodeAnalysis.NetAnalyzers (debatable, but feels appropriate in this case); the reason being that StyleCop analyzers (even custom non-deprecated builds) are not always aware about newest C# features for .NET 8 target.
Fixed nullable references issues and other minor issues
Moved packages for unit tests out of .props file
Upgraded xUnit
Upgraded the rest of packages in unit tests
Added packages packages.lock.json for repeatable restore