Skip to content

Comments

Add about app plugin#53

Open
EmogurovAnton wants to merge 3 commits intomainfrom
feature/add-about-app-plugin
Open

Add about app plugin#53
EmogurovAnton wants to merge 3 commits intomainfrom
feature/add-about-app-plugin

Conversation

@EmogurovAnton
Copy link
Contributor

No description provided.

verticalArrangement = Arrangement.spacedBy(8.dp),
contentPadding = PaddingValues(horizontal = 16.dp, vertical = 16.dp),
) {
items(items = state.aboutAppInfo, key = { it.title }) { item ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот тут мы же пользователя либы не ограничиваем использовать разные title, так что могут быть проблемы

package com.redmadrobot.debug.noop.plugin.aboutapp

class AboutAppPlugin(
private val aboutAppInfo: List<AboutAppInfo> = emptyList()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется лучше appInfoItems или appInfoList


@Immutable
internal data class AboutAppViewState(
val aboutAppInfo: List<AboutAppInfo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут тоже бы переименовать

import com.redmadrobot.debug.plugin.aboutapp.ui.AboutAppScreen

public class AboutAppPlugin(
private val aboutAppInfo: List<AboutAppInfo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут тоже


public data class AboutAppInfo(
val title: String,
val content: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб не content, а value?

@TopHlop
Copy link
Contributor

TopHlop commented Feb 19, 2026

Странно еще, что у нас нигде нет kdoc по всем плагинам

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants