Fix non-equi join error with equi + 2 inequality conditions (#7641)#7642
Merged
ben-schwen merged 2 commits intoRdatatable:masterfrom Feb 18, 2026
Merged
Conversation
…le#7641) When rightcols contains duplicates (same x column in multiple non-equi conditions), chmatchdup remaps them into the expanded result namespace. This overwrote rightcols, causing downstream code (e.g. .shallow(x, rightcols) in .join_result_key) to reference columns beyond ncol(x). Introduce ansrightcols for the remapped indices and keep rightcols as original column indices into x. Only icolsAns needs the remapped values; all other uses (xcols, names_x[rightcols], .join_result_key) need the original x-relative indices. Closes Rdatatable#7641
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7642 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 87 87
Lines 16896 16897 +1
=======================================
+ Hits 16732 16733 +1
Misses 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Basically LGTM. If you could thank yourself in the NEWS and add your name as contributor to DESCRIPTION, I can merge. |
ben-schwen
approved these changes
Feb 17, 2026
Per reviewer request: thank reporter in NEWS.md and add Tarun Thammisetty as contributor to DESCRIPTION.
Member
|
TY! @tarun-t I have invited you to become a project member of the Rdatatable organization. This makes feature PRs easier and also enables the atime jobs. Thank you for your contribution! |
Contributor
Author
|
Thank you for the invite! |
aitap
pushed a commit
that referenced
this pull request
Feb 18, 2026
* Fix non-equi join error with equi + 2 inequality conditions (#7641) When rightcols contains duplicates (same x column in multiple non-equi conditions), chmatchdup remaps them into the expanded result namespace. This overwrote rightcols, causing downstream code (e.g. .shallow(x, rightcols) in .join_result_key) to reference columns beyond ncol(x). Introduce ansrightcols for the remapped indices and keep rightcols as original column indices into x. Only icolsAns needs the remapped values; all other uses (xcols, names_x[rightcols], .join_result_key) need the original x-relative indices. Closes #7641 * Add contributor credit in DESCRIPTION and NEWS Per reviewer request: thank reporter in NEWS.md and add Tarun Thammisetty as contributor to DESCRIPTION.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7641. Non-equi joins combining an equality condition with two inequality conditions on the same column (e.g.,
on = .(id == id, val >= lo, val <= hi)) error on1.18.0+ due to
rightcolsbeing overwritten bychmatchdup.When
rightcolshas duplicates (samexcolumn in multiple conditions),chmatchdupremaps them into the expanded result namespacenx. This overwroterightcols,causing downstream code (
.shallow(x, rightcols)in.join_result_key) to reference columns beyondncol(x).Fix: Introduce
ansrightcolsfor the remapped indices, keeprightcolsas original column indices intox. OnlyicolsAnsneeds the remapped values; all otherdownstream uses need the original x-relative indices.
Changes
R/data.table.R: Replacerightcols = chmatchdup(...)withansrightcols = chmatchdup(...), useansrightcolsonly foricolsAnsinst/tests/tests.Rraw: Regression test (1483.91)NEWS.md: Bug fix entry