Draft
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3126/head:pr-3126
git checkout pr-3126This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3126/head |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ToothyDev
reviewed
Feb 26, 2026
Comment on lines
+44
to
+47
| if sys.version_info >= (3, 12): | ||
| from typing import TypeAliasType | ||
| else: | ||
| from typing_extensions import TypeAliasType |
Contributor
There was a problem hiding this comment.
IMO you should always import from typing_extension to avoid potentially differing behavior, also haven't seen this kind of version check myself yet in the lib so idk
Member
There was a problem hiding this comment.
Here specifically I don't think it works, bc we do instance checks on it. Could you confirm that @Soheab ?
Contributor
Author
There was a problem hiding this comment.
This is the current code fwiw, new code is in the options.py module.
9 tasks
This was
linked to
issues
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overrides #2919
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.