feat: General enhancements for views#3093
Open
NeloBlivion wants to merge 113 commits intoPycord-Development:masterfrom
Open
feat: General enhancements for views#3093NeloBlivion wants to merge 113 commits intoPycord-Development:masterfrom
NeloBlivion wants to merge 113 commits intoPycord-Development:masterfrom
Conversation
* fix(actions): rework release workflow * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-Authored-By: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
NeloBlivion
requested review from
Icebluewolf,
JustaSqu1d,
Lulalaby and
Lumabots
Member
Author
|
probably complete, have fun testing xo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace_itemadded toDesignerView,ActionRow,Section,Container, andMediaGalleryadd_itemsupports positioning with parametersbefore,after, andindexget_itemsupports getting items by any attribute instead of justidandcustom_idMessage.get_viewto retrieve a stored view or generate a new viewlen(View)to get the true item count in a viewadd_xvariants on DesignerViewadd_textandadd_labelon DesignerModalDesignerModal.from_dictInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.