Skip to content

Conversation

@ToothyDev
Copy link
Contributor

@ToothyDev ToothyDev commented Dec 29, 2025

Summary

This PR makes it so the docs for ForwardedMessage and MessageSnapshot actually render in the docs, as well as initialising the documented ForwardedMessage.mentions and ForwardedMessage.type property, see #3050

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@pycord-app
Copy link

pycord-app bot commented Dec 29, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3051/head:pr-3051
git checkout pr-3051

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3051/head

@ToothyDev ToothyDev marked this pull request as ready for review December 29, 2025 21:19
@ToothyDev
Copy link
Contributor Author

ToothyDev commented Dec 29, 2025

The length of data["mentions"] was 0 whenever the forwarded message came from either DMs or a different server, so for some reason this only seems to be able to be populated when message is forwarded within a server. Not sure if this is a Discord limitation, but seems so.

Should this be part of the docstring?

@ToothyDev ToothyDev changed the title fix: 🐛 Fix docs rendering for ForwardedMessage and MessageSnapshot and add missing .mentions property fix: 🐛 Fix docs rendering for ForwardedMessage and MessageSnapshot and add missing attributes Dec 29, 2025
@ToothyDev ToothyDev marked this pull request as draft December 29, 2025 22:26
Paillat-dev
Paillat-dev previously approved these changes Dec 30, 2025
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This knowingly doesn't work yet due to a Discord limitation / unresolved discussion on the API. A warning in the docs is in place
Paillat-dev
Paillat-dev previously approved these changes Dec 30, 2025
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works; code lgtm

@Paillat-dev Paillat-dev added this to the v2.7.1 milestone Dec 30, 2025
@Paillat-dev Paillat-dev linked an issue Dec 30, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with ForwardedMessage

3 participants