[perf] Use TryGetValue for net module handler resolution#3229
Merged
hakusaro merged 1 commit intoPryaxis:general-develfrom Mar 5, 2026
Merged
Conversation
Replace double dictionary lookup (ContainsKey + indexer) with a single TryGetValue path in NetModulePacketHandler. This is a small but safe hot-path cleanup.
Greptile SummaryThis PR optimizes the net module packet handler by replacing a double dictionary lookup with a single
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 4ba2f1b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This path runs for every net module packet.
This patch replaces a double dictionary lookup (
ContainsKey+ indexer) with a singleTryGetValuelookup.Behavior stays the same; it is only a small hot-path cleanup.