-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update the docstrings to match the actual code defaults #8700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
… the weight for positive samples of class c. Negative samples should have a default weight of 1.0 Signed-off-by: ytl0623 <[email protected]>
Signed-off-by: ytl0623 <[email protected]>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe focal loss module has been extended to support per-class alpha weighting. The FocalLoss class and softmax/sigmoid focal loss functions now accept alpha as either a scalar or a sequence of class weights, with updated signatures and validation logic. Scalar alpha follows the standard background/other-class weighting pattern, while sequence alpha applies per-class weights with appropriate broadcasting. In unified focal loss, docstrings were corrected to reflect actual gamma defaults: 2.0 for AsymmetricFocalLoss and 0.5 for AsymmetricUnifiedFocalLoss. Tests now verify alpha sequence broadcasting across multiple device and configuration combinations. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (3)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #8689 .
Description
Update the docstrings to match the actual code defaults.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.