Skip to content

Updating data_config.json with HF links and hashes #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
e-mny wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Updating data_config.json with HF links and hashes #8699

e-mny wants to merge 2 commits into from

Conversation

@e-mny
Copy link

@e-mny e-mny commented Jan 15, 2026

Fixes #8510

Description

The data_config.json needs to be updated with HF links in view of migrating to HF.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

A configuration file updating test data resource URLs from GitHub releases to HuggingFace datasets. Changes include replacing URLs for images, videos, and model weights across multiple entries, with corresponding hash_type conversions from md5/sha512 to sha256. File structure and entry organization remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly and concisely summarizes the main change: updating data_config.json with HuggingFace links and hash values.
Description check ✅ Passed Description covers the purpose (HF migration), links to the issue, and marks the change type; however, missing detailed explanation of what was updated.
Linked Issues check ✅ Passed PR directly addresses issue #8510 by migrating test data URLs from GitHub releases to HuggingFace dataset as requested.
Out of Scope Changes check ✅ Passed All changes are confined to data_config.json with URL and hash updates, directly aligned with the linked issue's migration objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 57fdd59 and ae4b961.

📒 Files selected for processing (1)
  • tests/testing_data/data_config.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: quick-py3 (windows-latest)
  • GitHub Check: quick-py3 (macOS-latest)
  • GitHub Check: flake8-py3 (pytype)
  • GitHub Check: flake8-py3 (codeformat)
  • GitHub Check: packaging
  • GitHub Check: quick-py3 (ubuntu-latest)
  • GitHub Check: flake8-py3 (mypy)
  • GitHub Check: min-dep-pytorch (2.8.0)
  • GitHub Check: build-docs
  • GitHub Check: min-dep-pytorch (2.6.0)
  • GitHub Check: min-dep-pytorch (2.5.1)
  • GitHub Check: min-dep-py3 (3.10)
  • GitHub Check: min-dep-py3 (3.12)
  • GitHub Check: min-dep-os (ubuntu-latest)
  • GitHub Check: min-dep-pytorch (2.7.1)
  • GitHub Check: min-dep-os (macOS-latest)
  • GitHub Check: min-dep-py3 (3.11)
  • GitHub Check: min-dep-py3 (3.9)
  • GitHub Check: min-dep-os (windows-latest)
🔇 Additional comments (3)
tests/testing_data/data_config.json (3)

94-105: LGTM!

Videos section fully migrated with consistent sha256 hashes.

106-162: LGTM!

Models section fully migrated with consistent URL format and sha256 hashes.

163-169: test_meta_file uses GitHub while model weights use HuggingFace.

This is a JSON schema file (not test data) used for metadata validation. The inconsistency may be intentional—model weights were migrated to HuggingFace with sha256 hashes, while schema/infrastructure files remain on GitHub with md5. If migration is desired, note that the same URL is also referenced in tests/testing_data/metadata.json and documentation, requiring coordinated updates.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@e-mny e-mny mentioned this pull request Jan 15, 2026
Open
coderabbitai[bot]
coderabbitai bot reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tests/testing_data/data_config.json (1)

88-92: Migrate nrrd_example to HuggingFace.

The file exists on HuggingFace but the URL still points to GitHub releases. Update to https://huggingface.co/datasets/MONAI/testing_data/resolve/main/CT_IMAGE_cropped.nrrd for consistency with other entries.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 57fdd59 and ae4b961.

📒 Files selected for processing (1)
  • tests/testing_data/data_config.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: quick-py3 (windows-latest)
  • GitHub Check: quick-py3 (macOS-latest)
  • GitHub Check: flake8-py3 (pytype)
  • GitHub Check: flake8-py3 (codeformat)
  • GitHub Check: packaging
  • GitHub Check: quick-py3 (ubuntu-latest)
  • GitHub Check: flake8-py3 (mypy)
  • GitHub Check: min-dep-pytorch (2.8.0)
  • GitHub Check: build-docs
  • GitHub Check: min-dep-pytorch (2.6.0)
  • GitHub Check: min-dep-pytorch (2.5.1)
  • GitHub Check: min-dep-py3 (3.10)
  • GitHub Check: min-dep-py3 (3.12)
  • GitHub Check: min-dep-os (ubuntu-latest)
  • GitHub Check: min-dep-pytorch (2.7.1)
  • GitHub Check: min-dep-os (macOS-latest)
  • GitHub Check: min-dep-py3 (3.11)
  • GitHub Check: min-dep-py3 (3.9)
  • GitHub Check: min-dep-os (windows-latest)
🔇 Additional comments (3)
tests/testing_data/data_config.json (3)

94-105: LGTM!

Videos section fully migrated with consistent sha256 hashes.

106-162: LGTM!

Models section fully migrated with consistent URL format and sha256 hashes.

163-169: test_meta_file uses GitHub while model weights use HuggingFace.

This is a JSON schema file (not test data) used for metadata validation. The inconsistency may be intentional—model weights were migrated to HuggingFace with sha256 hashes, while schema/infrastructure files remain on GitHub with md5. If migration is desired, note that the same URL is also referenced in tests/testing_data/metadata.json and documentation, requiring coordinated updates.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@KumoLiu KumoLiu Awaiting requested review from KumoLiu KumoLiu is a code owner

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Moving Testing Data to HuggingFace

1 participant

@e-mny