add vite doc to upload sourcemaps #14216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpouillot
requested review from
a team,
ablaszkiewicz,
daibhin and
oliverb123
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sarahxsanders
requested changes
Dec 22, 2025
Contributor
sarahxsanders
left a comment
sarahxsanders
left a comment
There was a problem hiding this comment.
looks good @hpouillot!! I left some suggestions for some slight improvements for readability then this is ready to go!!
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
Co-authored-by: Sarah Sanders <[email protected]>
daibhin
approved these changes
Dec 30, 2025
gewenyu99
approved these changes
Jan 5, 2026
Contributor
gewenyu99
left a comment
gewenyu99
left a comment
There was a problem hiding this comment.
These look good.
A little worried about the div with hidden overflow. If the website's css/layout changes, it could break. If this is the best solution for now, tho, all good with me.
|
|
||
| Set the following environment variables: | ||
|
|
||
| <div className="overflow-x-hidden"> |
Contributor
There was a problem hiding this comment.
Why did we go with overflow-x-hidden? That seems sus
Contributor
Author
There was a problem hiding this comment.
It's a copy paste from the nextjs doc but we should maybe share more code between pages and fix this as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes