Enable and improve mypy typechecking#2422
Open
VeckoTheGecko wants to merge 16 commits intoParcels-code:v4-devfrom
Open
Enable and improve mypy typechecking#2422VeckoTheGecko wants to merge 16 commits intoParcels-code:v4-devfrom
VeckoTheGecko wants to merge 16 commits intoParcels-code:v4-devfrom
Conversation
VeckoTheGecko
force-pushed
the
enable-mypy
branch
2 times, most recently
from
5bb5967 to
0a263d0
Compare
VeckoTheGecko
force-pushed
the
enable-mypy
branch
from
0a263d0 to
e9bc355
Compare
- remove _discover_U_and_V - move helper function
Allowing for gradual resolution
VeckoTheGecko
force-pushed
the
enable-mypy
branch
from
fdd6674 to
20fe435
Compare
Contributor
Author
|
Is this good to go? |
Contributor
Author
|
oops, looks like I rebased wrong - I'll fix this once I'm back from leave |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is incremental work fixing typechecking errors in parcels using Parcels. Besides fixing mypy errors, we have the following changes:
CfAxesinparcels._typingI have enabled the typechecking in CI - it isn't passing yet, but I will be working in future PRs to reduce the number of errors. This workflow can also be run using
pixi run typing.