Re-enable integration test CI#2359
Open
VeckoTheGecko wants to merge 1 commit intoParcels-code:v4-devfrom
Open
Conversation
Contributor
Author
Note this comment (and this PR) might not be necessary depending on the outcome of #2335 |
aff7bd8 to
c7ee875
Compare
c7ee875 to
52e76b3
Compare
Contributor
|
I’m not sure I fully understand what’s going on yet, but I am pinging computationalmodelling/nbval#151 here for our reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@erikvansebille flagged to me that integration tests weren't actually being run in CI.
Also, I realised that the notebooks integration tests aren't working.
pixi run -e test-notebooks-latest test-notebooksgives the following error - @reint-fischer would you mind looking into this if you have the time?: