Open
Conversation
jpenilla
approved these changes
Feb 22, 2026
Machine-Maker
approved these changes
Feb 26, 2026
Member
|
Would it be worth "deprecating" these first? (updating description + logging warnings when used). Chances are low of any of these still being used, but having a warning logged is a lot more pleasant than the server not starting. |
Member
Author
|
I honestly do not think it's worth the effort. Barely anyone probably knows that they even exist, even less of those people use them, and probably no one of those people is on the latest version anyways, since those args probably haven't done anything for a short while now. |
Lulu13022002
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back the missing
--bonusChestargument and removes currently unused options.